kgabryje commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r895717180
##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
});
+ // it('getColorFunction EQUAL inverse', () => {
Review Comment:
As for the available colours, those were selected for feature parity with a
heatmapping functionality that existed before.
I like the idea of allowing picking more colors/typing hex! What would work
even better is somehow adding a color picker to the modal instead of letting
user manually type hex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
