ege-st commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1293815319
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
@zhaoyongjie agreed, I started looking to see if this is a bug in Pinot or
in Calcite but I also want to see if I can get the fix done entirely within
Superset because upgrading the Superset version will be easier than upgrading
the Pinot deployment and, just in case, the fix in Calcite or Pinot takes a
while to get done.
I'll take a look at the Superset changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
