villebro commented on code in PR #29286:
URL: https://github.com/apache/superset/pull/29286#discussion_r1644437052
##########
superset/utils/lock.py:
##########
@@ -77,21 +82,23 @@ def KeyValueDistributedLock( # pylint: disable=invalid-name
from superset.commands.key_value.delete import DeleteKeyValueCommand
from superset.commands.key_value.delete_expired import
DeleteExpiredKeyValueCommand
- key = uuid.uuid5(uuid.uuid5(uuid.NAMESPACE_DNS, namespace),
serialize(kwargs))
+ key = get_key(namespace, **kwargs)
logger.debug("Acquiring lock on namespace %s for key %s", namespace, key)
try:
DeleteExpiredKeyValueCommand(resource=KeyValueResource.LOCK).run()
CreateKeyValueCommand(
resource=KeyValueResource.LOCK,
- codec=PickleKeyValueCodec(),
+ codec=JsonKeyValueCodec(),
Review Comment:
This is fixed in a separate PR (I had to pull in the change here as the test
needed to be updated): #29285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
