nytai commented on code in PR #29286:
URL: https://github.com/apache/superset/pull/29286#discussion_r1644954794
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -62,6 +63,7 @@ def run(self) -> str:
codec=self.codec,
).run()
assert key.id # for type checks
+ db.session.commit()
Review Comment:
i think there's a case to be made for both. Maybe we can have default
behavior be to commit but provide an option to skip for use cases where there's
a command chaining multiple sub-commands? It would be inconsistent for some
commands to commit while others requiring the caller to commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
