villebro commented on code in PR #29286:
URL: https://github.com/apache/superset/pull/29286#discussion_r1644836178
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -62,6 +63,7 @@ def run(self) -> str:
codec=self.codec,
).run()
assert key.id # for type checks
+ db.session.commit()
Review Comment:
Here I'm proposing to not commit in these commands, as we have cases where
we want to chain multiple commands together. But if we consider each Key Value
command a unit of work, then we should naturally commit there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
