michael-s-molina commented on code in PR #29286:
URL: https://github.com/apache/superset/pull/29286#discussion_r1647489486
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -62,6 +63,7 @@ def run(self) -> str:
codec=self.codec,
).run()
assert key.id # for type checks
+ db.session.commit()
Review Comment:
> This would make it possible to use all existing commands both as full
units of work, or as part of a bigger chain, with minimal code duplication
We'll achieve that with nested transactions using
[being_nested](https://docs.sqlalchemy.org/en/20/orm/session_api.html#sqlalchemy.orm.Session.begin_nested).
Check https://github.com/apache/superset/pull/24969 for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
