john-bodley commented on code in PR #29286:
URL: https://github.com/apache/superset/pull/29286#discussion_r1644818384
##########
superset/commands/dashboard/permalink/create.py:
##########
@@ -62,6 +63,7 @@ def run(self) -> str:
codec=self.codec,
).run()
assert key.id # for type checks
+ db.session.commit()
Review Comment:
Does the `UpsertKeyValueCommand` not commit? Note that _hopefully_ (if
merged) that https://github.com/apache/superset/pull/24969 should remove the
need to have to commit in various places given it violates the "unit of work"
philosophy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
