geido commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1930291201
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts:
##########
@@ -226,7 +226,7 @@ describe('Horizontal FilterBar', () => {
cy.getBySel('slice-header').within(() => {
cy.get('.filter-counts').trigger('mouseover');
});
- cy.get('.filterStatusPopover').contains('test_9').click();
+ cy.get('[data-test="filter-status-popover"]').contains('test_9').click();
Review Comment:
```suggestion
cy.getBySel('filter-status-popover').contains('test_9').click();
```
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -657,13 +656,13 @@ const DashboardBuilder = () => {
</Droppable>
</StyledHeader>
<StyledContent fullSizeChartId={fullSizeChartId}>
- <Global
+ {/* <Global
Review Comment:
Was this intended? Should we just remove it?
##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -366,10 +362,15 @@ const DropdownContainer = forwardRef(
`}
/>
<Popover
+ overlayInnerStyle={{
+ maxHeight: `${MAX_HEIGHT}px`,
+ overflow: showOverflow ? 'auto' : 'visible',
+ padding: `${theme.gridUnit * 3}px ${theme.gridUnit * 4}px`,
+ }}
Review Comment:
Are these required? Can we go with vanilla Ant Design?
##########
superset-frontend/src/components/Popover/index.tsx:
##########
@@ -16,9 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-export type { PopoverProps } from 'antd/lib/popover';
-export type { TooltipPlacement } from 'antd/lib/tooltip';
+import { Popover as AntdPopover } from 'antd-v5';
+import { PopoverProps as AntdPopoverProps } from 'antd-v5/lib/popover';
-// Eventually Popover can be wrapped and customized in this file
-// for now we're just redirecting
-export { Popover as default } from './Popover';
+export interface PopoverProps extends AntdPopoverProps {
+ forceRender?: boolean;
Review Comment:
What is this for? I don't see `forceRender` exposed in the Popover props of
Ant Design. Will this have any effect?
##########
superset-frontend/src/explore/components/DataTableControl/index.tsx:
##########
@@ -189,7 +189,7 @@ const DataTableTemporalHeaderCell = ({
{/* hack to disable click propagation from popover content to table
header, which triggers sorting column */}
<Global
styles={css`
- .column-formatting-popover .ant-popover-inner-content {
+ .column-formatting-popover .antd5-popover-inner-content {
padding: 0;
Review Comment:
Do we need this?
##########
superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx:
##########
@@ -224,12 +175,13 @@ const DetailsPanelPopover = ({
return (
<Popover
- overlayClassName="filterStatusPopover"
+ color={`${theme.colors.grayscale.dark2}cc`}
Review Comment:
Is this required? How is vanilla going to look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
