Re: [PR] refactor(Popover): Upgrade Popover to Antd5 [superset]

Tue, 28 Jan 2025 01:05:59 -0800 


alexandrusoare commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1931776231


##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -366,10 +362,15 @@ const DropdownContainer = forwardRef(
               `}
             />
             <Popover
+              overlayInnerStyle={{
+                maxHeight: `${MAX_HEIGHT}px`,
+                overflow: showOverflow ? 'auto' : 'visible',
+                padding: `${theme.gridUnit * 3}px ${theme.gridUnit * 4}px`,
+              }}

Review Comment:
   Yes they are required, if the `maxHeight` is not provided than the popover, 
depending on the number of items, it will stretch over the whole page, also 
`overflow` is required, maybe the `padding` is not really needed, as there's 
not a big visual difference:
   With padding:
   
![image](https://github.com/user-attachments/assets/42242366-c517-4926-af86-dad017a84ade)
   
   No padding:
   
![image](https://github.com/user-attachments/assets/c23b643a-8ce0-465e-a688-de504734a07a)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to