alexandrusoare commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1936831047


##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -181,11 +181,13 @@ const DropdownContainer = forwardRef(
     );
 
     useLayoutEffect(() => {
+      if (popoverVisible) {

Review Comment:
   No, I don't think so, I added this statement because of a visual bug that 
was happening in certain cases. And I think that we don't need to recalculate 
the size when popover is closed .  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to