geido commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1939708794
##########
superset-frontend/src/components/Popover/index.tsx:
##########
@@ -16,9 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-export type { PopoverProps } from 'antd/lib/popover';
-export type { TooltipPlacement } from 'antd/lib/tooltip';
+import { Popover as AntdPopover } from 'antd-v5';
+import { PopoverProps as AntdPopoverProps } from 'antd-v5/lib/popover';
-// Eventually Popover can be wrapped and customized in this file
-// for now we're just redirecting
-export { Popover as default } from './Popover';
+export interface PopoverProps extends AntdPopoverProps {
+ forceRender?: boolean;
Review Comment:
I am not sure this answers my question. If `forceRender` is not an option
that `Popover` accepts in Ant Design, what is the use of it?
##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -366,10 +362,15 @@ const DropdownContainer = forwardRef(
`}
/>
<Popover
+ overlayInnerStyle={{
+ maxHeight: `${MAX_HEIGHT}px`,
+ overflow: showOverflow ? 'auto' : 'visible',
+ padding: `${theme.gridUnit * 3}px ${theme.gridUnit * 4}px`,
+ }}
Review Comment:
Ok, can we remove the padding then?
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -657,13 +656,13 @@ const DashboardBuilder = () => {
</Droppable>
</StyledHeader>
<StyledContent fullSizeChartId={fullSizeChartId}>
- <Global
+ {/* <Global
Review Comment:
It looks like this is still here?
##########
superset-frontend/src/theme/index.ts:
##########
@@ -181,6 +181,7 @@ const baseConfig: ThemeConfig = {
},
Popover: {
colorBgElevated: supersetTheme.colors.grayscale.light5,
+ zIndexPopup: supersetTheme.zIndex.max,
Review Comment:
This is still the same. Have you acknowledged this comment?
##########
superset-frontend/src/explore/components/DataTableControl/index.tsx:
##########
@@ -189,7 +189,7 @@ const DataTableTemporalHeaderCell = ({
{/* hack to disable click propagation from popover content to table
header, which triggers sorting column */}
<Global
styles={css`
- .column-formatting-popover .ant-popover-inner-content {
+ .column-formatting-popover .antd5-popover-inner-content {
padding: 0;
Review Comment:
?
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/index.tsx:
##########
@@ -43,15 +44,20 @@ export const FilterCard = ({
return (
<Popover
placement={placement}
- overlayClassName="filter-card-popover"
+ overlayStyle={{
+ width: '240px',
+ padding: 0,
+ borderRadius: `${theme.gridUnit}px`,
Review Comment:
Do we need the border radius at all here? can we rely on vanilla Ant Design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
