alexandrusoare commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1931881438
##########
superset-frontend/src/components/Popover/index.tsx:
##########
@@ -16,9 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-export type { PopoverProps } from 'antd/lib/popover';
-export type { TooltipPlacement } from 'antd/lib/tooltip';
+import { Popover as AntdPopover } from 'antd-v5';
+import { PopoverProps as AntdPopoverProps } from 'antd-v5/lib/popover';
-// Eventually Popover can be wrapped and customized in this file
-// for now we're just redirecting
-export { Popover as default } from './Popover';
+export interface PopoverProps extends AntdPopoverProps {
+ forceRender?: boolean;
Review Comment:
This was being used before, I just combined the `Popover.tsx` file with the
`index.tsx` file ->
https://github.com/apache/superset/pull/31973/files/18ef69e7e88cc0389c4dd991050e176988acb9e8#diff-575bb0af856e1f113959bcf0ec737a412cb23b3b5ed154012d993d5be95da187
And the `forceRender` prop is being used in some places, here's 1 for
example: `superset/superset-frontend/src/components/DropdownContainer/index.tsx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
