alexandrusoare commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1940841106
##########
superset-frontend/src/components/Popover/index.tsx:
##########
@@ -16,9 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-export type { PopoverProps } from 'antd/lib/popover';
-export type { TooltipPlacement } from 'antd/lib/tooltip';
+import { Popover as AntdPopover } from 'antd-v5';
+import { PopoverProps as AntdPopoverProps } from 'antd-v5/lib/popover';
-// Eventually Popover can be wrapped and customized in this file
-// for now we're just redirecting
-export { Popover as default } from './Popover';
+export interface PopoverProps extends AntdPopoverProps {
+ forceRender?: boolean;
Review Comment:
The `forceRender` option ensures that the Popover’s content is rendered in
the DOM even when the Popover is not opened. I verified that it behaves as
expected, which confirms that it works even though it isn’t an official prop in
Ant Design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
