geido commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1939707640
##########
superset-frontend/src/components/DropdownContainer/index.tsx:
##########
@@ -366,10 +362,15 @@ const DropdownContainer = forwardRef(
`}
/>
<Popover
+ overlayInnerStyle={{
+ maxHeight: `${MAX_HEIGHT}px`,
+ overflow: showOverflow ? 'auto' : 'visible',
+ padding: `${theme.gridUnit * 3}px ${theme.gridUnit * 4}px`,
+ }}
Review Comment:
Ok, can we remove the padding then?
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -657,13 +656,13 @@ const DashboardBuilder = () => {
</Droppable>
</StyledHeader>
<StyledContent fullSizeChartId={fullSizeChartId}>
- <Global
+ {/* <Global
Review Comment:
It looks like this is still here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
