Re: [PR] refactor(Popover): Upgrade Popover to Antd5 [superset]

Tue, 04 Feb 2025 01:57:00 -0800 


alexandrusoare commented on code in PR #31973:
URL: https://github.com/apache/superset/pull/31973#discussion_r1940855884


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/index.tsx:
##########
@@ -43,15 +44,20 @@ export const FilterCard = ({
   return (
     <Popover
       placement={placement}
-      overlayClassName="filter-card-popover"
+      overlayStyle={{
+        width: '240px',
+        padding: 0,
+        borderRadius: theme.borderRadius,

Review Comment:
   Yes, I think we can rely on the defaults here
   
   Without Padding: 
   
![image](https://github.com/user-attachments/assets/0e385258-51ea-48b0-9668-ba86abfd81f4)
   With Padding:
   
![image](https://github.com/user-attachments/assets/c5cad152-4ce8-4f6f-a5af-68cb6e3a433d)
   Without Border:
   
![image](https://github.com/user-attachments/assets/3131ab76-5f47-4115-9ba0-81c73b97014b)
   With Border:
   
![image](https://github.com/user-attachments/assets/e2e15788-7369-4804-8a45-08ea119319c0)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to