Re: [PR] feat(Select): Select all and Deselect all that works on visible items while searching [superset]

[via GitHub]

msyavuz commented on PR #33043:
URL: https://github.com/apache/superset/pull/33043#issuecomment-2812051087

   > 1 - Can we reduce the actions padding?
   > <img alt="Screenshot 2025-04-16 at 16 36 29" width="242" 
src="https://private-user-images.githubusercontent.com/70410625/434497998-cb69d03e-c77e-44a3-8dad-75925f682cd1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ4NzUxMjUsIm5iZiI6MTc0NDg3NDgyNSwicGF0aCI6Ii83MDQxMDYyNS80MzQ0OTc5OTgtY2I2OWQwM2UtYzc3ZS00NGEzLThkYWQtNzU5MjVmNjgyY2QxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDE3VDA3MjcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTljOWEzYzMzZTgxZjYwNzZjODgyM2ZmMDVhYjEyNGUxNGM5NTY3MDI2OThlNzUyOTVjZTczZWY2OTM0MzZkYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.nf7E3bZnsAgJCFeJUmz2LbDOhrqyloy8b5ZhQEa7Kpg";>
   > 
   > 2 - The Select all action is not counting and selecting new options.
   > <img alt="Screenshot 2025-04-16 at 16 37 07" width="244" 
src="https://private-user-images.githubusercontent.com/70410625/434498429-c1d172d4-d364-4ddd-b87a-e49608f3149f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ4NzUxMjUsIm5iZiI6MTc0NDg3NDgyNSwicGF0aCI6Ii83MDQxMDYyNS80MzQ0OTg0MjktYzFkMTcyZDQtZDM2NC00ZGRkLWI4N2EtZTQ5NjA4ZjMxNDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDE3VDA3MjcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJlZjRiYTcwNmEyOWFiZWJhZDAwZDU4NmUwM2YyMDg4NGQxNjk5NWNkY2M2NmIzNjlmMjRmNDM2MGFkOWM1NTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.XKk5hTYIEPglM9BuxXEnXntxIUrlcQ35iVkTlmZ7B7A";>
   > 
   > 3 - I was also able to reproduce the No data when typing fast.
   > <img alt="Screenshot 2025-04-16 at 16 44 15" width="246" 
src="https://private-user-images.githubusercontent.com/70410625/434500409-f0db1a83-b82c-4217-a86a-cba60dc97a93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDQ4NzUxMjUsIm5iZiI6MTc0NDg3NDgyNSwicGF0aCI6Ii83MDQxMDYyNS80MzQ1MDA0MDktZjBkYjFhODMtYjgyYy00MjE3LWE4NmEtY2JhNjBkYzk3YTkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDE3VDA3MjcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE1YWFmOTM3YzE3ZGUyMDMyMGQ0ZjA2OTBlYjc1OGU0NmUyY2E5N2VmNjc3MjU1ZGQyOWY4ZmVkYzI2YzdhZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.i5dlCplcajqELC9YZeyR0sbLKDxrj2jrkCT_SxHQCRw";>
   
   1) We can, done!
   2) That was by design to prevent accidental new options when user is trying 
to filter with select/deselect all.
   3) I think this is the debounce?
   
   What concerned me in the screenshots is the Deselect all button not being 
disabled when no options are selected. I remember fixing this, did you test on 
branch latest?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org