michael-s-molina commented on PR #33043: URL: https://github.com/apache/superset/pull/33043#issuecomment-2812623813
@msyavuz I noticed you removed some tests for previous behaviors that don't exist anymore but there are no new tests. Some possible tests would include: - Deselect counting, enable/disable, etc. - Select all counting with new items - Select all counting with search - Maybe we can try to add a test for the 'No data' bug too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
