michael-s-molina commented on PR #33043: URL: https://github.com/apache/superset/pull/33043#issuecomment-2812607810
> I agree with what @msyavuz said above too, I also think the primary expected action when typing in the field is filtering the values and not really creating a new filter in this case. So that's why we opted for selecting [all] of the existing values instead of selecting everything you see in the dropdown. > We also wanted to add indicators for existing vs new values in the dropdown, to make it easier to understand, but ant-d does not support that currently. @kasiazjc This makes sense. It would be better though if we had some indication for new values. Did we consider showing a text suffix for new items like `(+) John Doe` or `(new) John Doe` that is displayed only when the dropdown is open? > What concerned me in the screenshots is the Deselect all button not being disabled when no options are selected. I remember fixing this, did you test on branch latest? @msyavuz I used the latest [test environment](https://github.com/apache/superset/pull/33043#issuecomment-2809377937) given that I didn't see any commit after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
