msyavuz commented on PR #33043: URL: https://github.com/apache/superset/pull/33043#issuecomment-2812762998
> @kasiazjc This makes sense. It would be better though if we had some indication for new values. Did we consider showing a text suffix for new items like (+) John Doe or (new) John Doe that is displayed only when the dropdown is open? We did consider something similar but Ant design v4 doesn't have the `optionRender` prop yet and there is no reliable way to discern newOptions in input box vs newOptions in dropdown. In v5 this will be much easier with `optionRender` prop. I agree on the tests part, tests on Select were really comprehensive and it will be best to keep it that way, i will add the necessary tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
