kasiazjc commented on PR #33043: URL: https://github.com/apache/superset/pull/33043#issuecomment-2812474572
> > 2 - The Select all action is not counting and selecting new options. > > @kasiazjc I don't think this should be the case as we have no indication that the user intends to actually create that new option or just filtering at that point, but I am curious to hear your thoughts on this. I agree with what @msyavuz said above too, I also think the primary expected action when typing in the field is filtering the values and not really creating a new filter in this case. So that's why we opted for selecting [all] of the existing values instead of selecting everything you see in the dropdown. We also wanted to add indicators for existing vs new values in the dropdown, to make it easier to understand, but ant-d does not support that currently. Even though this is the case, selecting existing ones is more intuitive/expected than creating a new value (that could have been random search phrase) in addition to select all action. Creating a new value should feel intentional, for example as right now - with hitting enter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
