endimonan commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2913072561
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -142,8 +147,11 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
inverseSelection,
defaultToFirstItem,
searchAllOptions,
+ operatorType = SelectFilterOperatorType.Exact,
} = formData;
+ const isLikeOperator = operatorType !== SelectFilterOperatorType.Exact;
Review Comment:
Good point, done. Now `isLikeOperator` also checks that the column's
datatype is `GenericDataType.String`, and the config modal only shows the
`ILIKE `options when the selected column is a string type. If someone switches
to a non-string column, it auto-resets to Exact match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
