endimonan commented on PR #38470: URL: https://github.com/apache/superset/pull/38470#issuecomment-4033137012
Added three new tests: one that types into the LIKE input and asserts setDataMask gets the ILIKE payload with correct wildcards, another for NOT ILIKE with inverse selection, and a clear-all test that verifies the input resets and the dataMask clears properly. > * The added tests are helpful, especially around rendering and extra form data generation. I think one more test would strengthen this: simulate typing into the new LIKE input and assert that setDataMask receives the expected ILIKE / NOT ILIKE payload. A clear-all or default-value sync test for LIKE mode would also help cover the new state-management path > * Also could you take a look at the bot suggestion please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
