endimonan commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2913192302
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -1693,6 +1713,57 @@ const FiltersConfigForm = (
)}
</CollapsibleControl>
</FormItem>
+ {!isChartCustomization && (
+ <StyledRowFormItem
+ expanded={expanded}
+ name={[
+ 'filters',
+ filterId,
+ 'controlValues',
+ 'operatorType',
+ ]}
+ initialValue={currentOperatorType}
+ label={
+ <>
+ <StyledLabel>{t('Match type')}</StyledLabel>
+
+ <InfoTooltip
+ placement="top"
+ tooltip={t(
+ 'Warning: ILIKE queries may be slow on
large datasets as they cannot use indexes effectively.',
+ )}
+ />
+ </>
+ }
+ >
+ <Select
Review Comment:
I considered that, but the two usages have different shapes (controlPanel
uses [value, label] tuples, FiltersConfigForm uses {value, label} objects) and
the config modal filters options conditionally based on column type. Extracting
a shared constant for 4 static labels felt like it would add indirection
without much gain. The enum itself is the source of truth for valid values, and
both files are in the same feature scope so drift is unlikely.
Happy to reconsider if you feel strongly about it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
