endimonan commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2911586907
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx:
##########
@@ -1249,3 +1250,133 @@ test('resets dependent filter to first item when value
does not exist in data',
);
});
});
+
+test('renders text input instead of dropdown when operatorType is ILIKE
contains', () => {
+ jest.useFakeTimers();
+ const setDataMaskMock = jest.fn();
+
+ render(
+ // @ts-expect-error
Review Comment:
Those are inherited from the existing tests, the getWrapper helper on line
83 already uses the same pattern. The issue is that transformProps returns a
type that doesn't fully match the component props. Fixing it properly would
mean reworking the return type or creating a test fixture type, so I'd rather
keep it consistent with what's already there and do that cleanup separately.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
