endimonan commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2913198084
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -624,6 +627,23 @@ const FiltersConfigForm = (
forceUpdate();
};
+ const currentOperatorType: SelectFilterOperatorType =
+ formFilter?.controlValues?.operatorType ??
+ filterToEdit?.controlValues?.operatorType ??
+ SelectFilterOperatorType.Exact;
+
+ const onOperatorTypeChanged = (value: SelectFilterOperatorType) => {
Review Comment:
Good call, added an explicit `defaultDataMask: null` reset inside
`onOperatorTypeChanged` so the filter value is cleared when switching between
match types. It already cleared naturally on save/re-mount, but now it's
explicit and consistent with how the rest of the form handles mode changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
