villebro commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r321414429
##########
File path: superset/connectors/druid/models.py
##########
@@ -952,12 +970,14 @@ def values_for_column(self, column_name, limit=10000):
client = self.cluster.get_pydruid_client()
client.topn(**qry)
df = client.export_pandas()
- return [row[column_name] for row in df.to_records(index=False)]
+ return df[column_name].to_list()
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
