mikebridge commented on PR #40128: URL: https://github.com/apache/superset/pull/40128#issuecomment-4652137457
**Latest review items addressed** (`5a9ca50646`): - Empty-string slug guard now has a test (`test_restore_dashboard_runs_conflict_check_for_empty_string_slug`) — pins that the `is not None` guard runs the conflict check for `""`. - **Translations:** added `msgid "Dashboard could not be restored."` to `messages.pot`. All 26 language `.po` files already carry the entry with an empty `msgstr` — the correct placeholder for translators (it falls back to English until translated). Actual translations are left to the i18n contributor workflow, so I'm resolving the per-language translation threads as placeholder-complete. - amin's SQLite migration-test precondition and the `bind` type-hint NIT are addressed (migration tests pass on SQLite; `bind: Connection` is typed). Resolving the corresponding threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
