mikebridge commented on PR #40128: URL: https://github.com/apache/superset/pull/40128#issuecomment-4662602314
@richardfogaca — thanks for the thorough passes. Rebased onto current master and addressed everything from the latest review and the June 5 follow-up: **Review (Jun 8)** - **Importer `needs_mutation` (Case B)** — keyed Case B on `is_soft_deleted` rather than the fused `needs_mutation`, so an *active* dashboard imported with `overwrite=True` but no `can_write` returns the existing row instead of raising the restore error. Added a regression test (`test_import_existing_active_dashboard_overwrite_without_can_write_returns_existing`). (736c579a70) - **Deleted-state listing access boundary** — scoped `dashboard_deleted_state=include|only` to the restore audience: non-admins only see soft-deleted dashboards they own (admins see all); live rows keep normal `DashboardAccessFilter` visibility. Mirrors `RestoreDashboardCommand`'s `raise_for_ownership`. Added integration coverage (owner sees own deleted; a read-access non-owner does not). (736c579a70) - **UPDATING.md MySQL version** — corrected to MySQL 8.0.13+ for the functional index; MySQL <8.0.13, MariaDB, and SQLite keep the full unique constraint. (736c579a70) **Follow-up (Jun 5)** - **Migration DDL ordering on MySQL** — good catch. Reordered both upgrade and downgrade to create the replacement unique index *first* and drop the previous one only after it succeeds, so a failed DDL leaves the stricter uniqueness in place (MySQL autocommits each statement). Postgres is unchanged — its transactional DDL already makes the drop+create atomic. (a44f7274ba) - **UPDATING.md `8.0+` wording** — folded into the doc fix above; the section now consistently says 8.0.13+ / MariaDB-excluded. All on the rebased branch (HEAD a44f7274ba). Ready for another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
