bito-code-review[bot] commented on code in PR #40128:
URL: https://github.com/apache/superset/pull/40128#discussion_r3375882105
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -4093,6 +4093,9 @@ msgstr "ダッシュボードの配色設定を更新できませんでした。
msgid "Dashboard could not be deleted."
msgstr "ダッシュボードを削除できませんでした。"
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Japanese translation</b></div>
<div id="fix">
The `msgstr` field is empty, causing Japanese users to see untranslated
English text when a dashboard restore operation fails. Add the translation
following the established pattern used for similar error messages in this file.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/superset/translations/ja/LC_MESSAGES/messages.po
+++ b/superset/translations/ja/LC_MESSAGES/messages.po
@@ -4093,8 +4093,8 @@
msgid "Dashboard could not be deleted."
msgstr "ダッシュボードを削除できませんでした。"
-msgid "Dashboard could not be restored."
-msgstr ""
-
+msgid "Dashboard could not be restored."
+msgstr "ダッシュボードを復元できませんでした。"
+
msgid "Dashboard could not be updated."
msgstr "ダッシュボードを更新できませんでした。"
```
</div>
</details>
</div>
<small><i>Code Review Run #11cc88</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/sk/LC_MESSAGES/messages.po:
##########
@@ -4416,6 +4416,9 @@ msgstr "Konfiguraci farieb nástenky sa nepodarilo
aktualizovať."
msgid "Dashboard could not be deleted."
msgstr "Nástenku sa nepodarilo zmazať."
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Slovak translation</b></div>
<div id="fix">
Empty translation string (`msgstr ""`) will display untranslated English
text "Dashboard could not be restored." to Slovak-speaking users when a
dashboard restore operation fails. Following the established Slovak pattern
from adjacent messages, the translation should be "Nástenku sa nepodarilo
obnoviť."
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/sk/LC_MESSAGES/messages.po
+++ superset/translations/sk/LC_MESSAGES/messages.po
@@ -4417,7 +4417,7 @@
msgstr "Nástenku sa nepodarilo zmazať."
msgid "Dashboard could not be restored."
-msgstr ""
+msgstr "Nástenku sa nepodarilo obnoviť."
msgid "Dashboard could not be updated."
msgstr "Nástenku sa nepodarilo aktualizovať."
```
</div>
</details>
</div>
<small><i>Code Review Run #11cc88</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh/LC_MESSAGES/messages.po:
##########
@@ -4384,6 +4384,9 @@ msgstr "看板无法更新。"
msgid "Dashboard could not be deleted."
msgstr "看板无法被删除。"
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Chinese translation</b></div>
<div id="fix">
The new translation entry for 'Dashboard could not be restored.' has an
empty `msgstr` value, while all adjacent entries in this block (lines
4384-4391) have complete Chinese translations. This creates an inconsistent
state where Chinese-speaking users will see an untranslated error message. Add
the translation following the established pattern: "看板无法被恢复。"
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/superset/translations/zh/LC_MESSAGES/messages.po
+++ b/superset/translations/zh/LC_MESSAGES/messages.po
@@ -4385,7 +4385,7 @@ msgstr "看板无法被删除。"
msgid "Dashboard could not be restored."
-msgstr ""
+msgstr "看板无法被恢复。"
msgid "Dashboard could not be updated."
msgstr "看板无法更新。"
```
</div>
</details>
</div>
<small><i>Code Review Run #11cc88</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -4466,6 +4466,9 @@ msgstr "Dashboard kon niet worden bijgewerkt."
msgid "Dashboard could not be deleted."
msgstr "Dashboard kon niet worden verwijderd."
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
The `msgstr` is empty, so Dutch users will see the untranslated English
message "Dashboard could not be restored." instead of a proper Dutch
translation. Following the established pattern (e.g., "Dashboard kon niet
worden verwijderd." for delete), the translation should be "Dashboard kon niet
worden hersteld.".
</div>
</div>
<small><i>Code Review Run #11cc88</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
