mikebridge commented on PR #40128: URL: https://github.com/apache/superset/pull/40128#issuecomment-4671975051
Triaged the open inline threads — resolved the non-actionable ones, left two open intentionally. **Resolved (not actionable):** - **`del_permission_role` "non-existent method"** — `del_permission_role(role, perm_view)` is a real FAB `SecurityManager` method, used throughout the existing suite (`tests/integration_tests/base_tests.py`, `security_tests.py`, `databases/api_tests.py`, `charts/api_tests.py`). It runs in the test's `finally` cleanup, which CI exercises — false positive. - **Empty `msgstr` in `sl`/`ru` `.po`** — intentional: an untranslated entry falls back to the English `msgid` until a translator fills it in; an empty `msgstr` is the correct placeholder, not a missing translation. - **MySQL migration "idempotency guard" suggestions** — declining: these are one-shot forward migrations and idempotent-DDL guards aren't the established pattern in this codebase. - **Function-level imports in tests** — acceptable per project convention (import-outside-toplevel in test bodies). - A couple of obsolete authoring self-notes. **Left open (tracked):** - `superset/commands/dashboard/importers/v1/utils.py:328` — the `needs_mutation` overwrite-vs-restore split (planned to land before the last soft-delete PR merges). - `superset/dashboards/api.py:1294` — optional extra coverage for the `DashboardRestoreFailedError` path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
