bito-code-review[bot] commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3382293519
########## superset/translations/nl/LC_MESSAGES/messages.po: ########## @@ -4688,6 +4688,9 @@ msgstr "Database instellingen bijgewerkt" msgid "Database type does not support file uploads." msgstr "Database ondersteunt geen subquery’s" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to provide a translation for the new string is noted. As you correctly identified, Superset's i18n workflow relies on Crowdin for external translation, and an empty `msgstr` is the standard initial state for new strings in the `.po` files. You may disregard this suggestion as it is a standard part of the localization process. **superset/translations/nl/LC_MESSAGES/messages.po** ``` +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" ``` ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -4655,6 +4655,9 @@ msgstr "Mise à jour des paramètres de la base de données" msgid "Database type does not support file uploads." msgstr "La base de données ne prend pas en charge le chargement de fichiers" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to provide a French translation for the new error message is not required in this instance. As you noted, Superset's i18n workflow relies on the Crowdin community to supply translations for new strings, and an empty `msgstr` is the standard, correct state for newly added strings in the `.po` files. ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -4604,6 +4604,9 @@ msgstr "数据库设置已更新" msgid "Database type does not support file uploads." msgstr "数据库不支持子查询" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The suggestion to add a size check to the metadata endpoint is correct and addresses a potential security bypass where oversized files could be parsed into memory. The reviewer's proposed fix is appropriate for the identified issue. Since this is a security-related improvement, it is recommended to apply the suggestion to ensure consistent enforcement of the file size limit across both the upload and metadata endpoints. ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -4563,6 +4563,9 @@ msgstr "La tua query non può essere salvata" msgid "Database type does not support file uploads." msgstr "Sorgente dati e tipo di grafico" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> Yes, Bito should avoid flagging empty `msgstr` entries in `.po` files for this project. As noted in the discussion, Superset's i18n workflow relies on the translator community via Crowdin to provide translations for new strings. Committing empty `msgstr` entries is the standard, intended state for new strings added in a PR, and manual translation within the PR would bypass the established translation process. ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -17928,10 +17931,6 @@ msgstr "Importa" msgid "value descending" msgstr "Importa" Review Comment: <!-- Bito Reply --> The suggestion to update the translation for 'value descending' is not appropriate for this pull request. As you noted, this is a pre-existing translation that is not being modified by your changes, and correcting it here would be out of scope. You should ignore this suggestion and address such translation issues through the project's dedicated localization process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
