rusackas commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3382291984
########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -4563,6 +4563,9 @@ msgstr "La tua query non può essere salvata" msgid "Database type does not support file uploads." msgstr "Sorgente dati e tipo di grafico" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: This is expected and correct for Superset's i18n workflow. New user-facing strings added with `_()` are extracted into the `.po` catalogs with an empty `msgstr ""`; translations are supplied separately by the translator community via Crowdin, not hand-written in the source PR. The empty entry here is the intended state, not a defect. ########## superset/translations/nl/LC_MESSAGES/messages.po: ########## @@ -4688,6 +4688,9 @@ msgstr "Database instellingen bijgewerkt" msgid "Database type does not support file uploads." msgstr "Database ondersteunt geen subquery’s" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: This is expected and correct for Superset's i18n workflow. New user-facing strings added with `_()` are extracted into the `.po` catalogs with an empty `msgstr ""`; translations are supplied separately by the translator community via Crowdin, not hand-written in the source PR. The empty entry here is the intended state, not a defect. ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -4655,6 +4655,9 @@ msgstr "Mise à jour des paramètres de la base de données" msgid "Database type does not support file uploads." msgstr "La base de données ne prend pas en charge le chargement de fichiers" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: This is expected and correct for Superset's i18n workflow. New user-facing strings added with `_()` are extracted into the `.po` catalogs with an empty `msgstr ""`; translations are supplied separately by the translator community via Crowdin, not hand-written in the source PR. The empty entry here is the intended state, not a defect. ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -17928,10 +17931,6 @@ msgstr "Importa" msgid "value descending" msgstr "Importa" Review Comment: This `value descending` -> `Importa` entry is a pre-existing translation that this PR does not introduce or modify; it only appears in the diff because of line-number shifts from the new string added nearby. Correcting an unrelated, already-merged Italian translation is out of scope for this PR and belongs in a dedicated i18n fix (ideally via Crowdin, the source of truth for translations). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
