rusackas commented on PR #40860: URL: https://github.com/apache/superset/pull/40860#issuecomment-4675927245
@hainenber good eye - that 100MB default is the knob from #40637, and this PR just consumes it rather than re-adding it. Reason it's still worth landing: #40637 only enforced the size *inside the columnar reader*, so CSV/Excel uploads (and the metadata endpoint) aren't bounded on master. This lifts the check up to `UploadCommand.validate` so every path gets one consistent 413. @rebenitez1802 good call on reconciling - rebased on master and dropped the now-duplicate `_check_file_size` from the columnar reader, since the base check runs before it ever gets there (the zip decompression-ratio guard stays). CI's running 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
