bito-code-review[bot] commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3393120438
########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -17,7 +17,7 @@ msgid "" msgstr "" "Project-Id-Version: PROJECT VERSION\n" "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n" -"POT-Creation-Date: 2026-06-05 12:59+0300\n" +"POT-Creation-Date: 2026-06-08 12:27-0700\n" "PO-Revision-Date: 2021-11-16 17:33+0100\n" "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" "Language: fr\n" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Locale mismatch in file header</b></div> <div id="fix"> The file header declares `Language: fr` and `Language-Team: fr`, but the file is located in the `pl/` (Polish) locale directory. This mismatch will cause translation extraction and compilation tools to misclassify the locale. Update both header fields to 'pl' and 'Polish <[email protected]>' respectively. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/pl/LC_MESSAGES/messages.po (lines 21-24) --- 21: "PO-Revision-Date: 2021-11-16 17:33+0100\n" 22: "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" 23: -"Language: fr\n" 23: +"Language: pl\n" 24: "Language-Team: fr <[email protected]>\n" 25: +"Language-Team: Polish <[email protected]>\n" ``` </div> </details> </div> <small><i>Code Review Run #939ba3</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -4790,6 +4790,9 @@ msgstr "Configurações do banco de dados atualizadas" msgid "Database type does not support file uploads." msgstr "O banco de dados não é compatível com subconsultas" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Portuguese translation</b></div> <div id="fix"> The new `DatabaseUploadFileTooLarge` exception message has an empty translation. Users will see untranslated English text "Database upload file exceeds the maximum allowed size." instead of Portuguese. This exception is raised in `superset/commands/database/uploaders/base.py` when file uploads exceed configured size limits. </div> </div> <small><i>Code Review Run #939ba3</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/sk/LC_MESSAGES/messages.po: ########## @@ -4633,6 +4633,9 @@ msgstr "Nastavenie databáza aktualizované" msgid "Database type does not support file uploads." msgstr "Typ databáza nepodporuje nahrávanie súborov." +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Slovak translation</b></div> <div id="fix"> The new message `Database upload file exceeds the maximum allowed size.` has an empty `msgstr` field. Slovak users will see the untranslated English text. Provide a Slovak translation following the established pattern of nearby database upload messages (e.g., "Nahranie súboru do databázy presahuje maximálnu povolenú veľkosť."). </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/sk/LC_MESSAGES/messages.po +++ b/superset/translations/sk/LC_MESSAGES/messages.po @@ -4634,7 +4634,7 @@ msgstr "Typ databáza nepodporuje nahrávanie súborov." msgid "Database upload file exceeds the maximum allowed size." -msgstr "" +msgstr "Nahranie súboru do databázy presahuje maximálnu povolenú veľkosť." msgid "Database upload file failed" msgstr "Nahranie súboru do databáza zlyhalo" ``` </div> </details> </div> <small><i>Code Review Run #939ba3</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/lv/LC_MESSAGES/messages.po: ########## @@ -4572,6 +4572,9 @@ msgstr "Datubāzes iestatījumi atjaunināti" msgid "Database type does not support file uploads." msgstr "Datubāzes tips neatbalsta failu augšupielādi." +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Latvian translation</b></div> <div id="fix"> The new translation entry for `DatabaseUploadFileTooLarge` message has an empty `msgstr` field. Latvian users will see the English error message instead of a localized one. Per rule 6516, all user-facing text should be properly translated. </div> </div> <small><i>Code Review Run #939ba3</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
