bito-code-review[bot] commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3393215413
########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -4790,6 +4790,9 @@ msgstr "Configurações do banco de dados atualizadas" msgid "Database type does not support file uploads." msgstr "O banco de dados não é compatível com subconsultas" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The empty `msgstr` is indeed expected for new source strings. Translators will populate these translations through the standard i18n workflow, not within the pull request that introduces the source string itself. The reviewer's suggestion to add a translation here is not necessary for this PR. **superset/translations/pt_BR/LC_MESSAGES/messages.po** ``` +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" ``` ########## superset/translations/lv/LC_MESSAGES/messages.po: ########## @@ -4572,6 +4572,9 @@ msgstr "Datubāzes iestatījumi atjaunināti" msgid "Database type does not support file uploads." msgstr "Datubāzes tips neatbalsta failu augšupielādi." +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The empty `msgstr` is the expected and correct state for new strings in this project's i18n workflow. Translations are managed externally via the community translation platform (Crowdin) and are not intended to be hand-written in the source PR. Committing a machine-generated translation would bypass the established translation review process, so leaving the field empty is the standard practice. ########## superset/translations/sk/LC_MESSAGES/messages.po: ########## @@ -4633,6 +4633,9 @@ msgstr "Nastavenie databáza aktualizované" msgid "Database type does not support file uploads." msgstr "Typ databáza nepodporuje nahrávanie súborov." +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <!-- Bito Reply --> The empty `msgstr` is expected because the Slovak translation for this new string is handled through the separate i18n workflow, not this pull request. The reviewer's suggestion to provide a translation is a standard check to ensure new strings are not left untranslated, but in this case, the translation process is managed externally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
