rusackas commented on code in PR #40860:
URL: https://github.com/apache/superset/pull/40860#discussion_r3407721958
##########
superset/commands/database/exceptions.py:
##########
@@ -118,6 +118,11 @@ class DatabaseUploadFailed(CommandException):
message = _("Database upload file failed")
+class DatabaseUploadFileTooLarge(CommandException):
+ status = 413
+ message = _("Database upload file exceeds the maximum allowed size.")
Review Comment:
Sorry, that last reply landed on the wrong thread. On this one: none of the
other exception classes in this file carry docstrings, so adding one just here
would be inconsistent. The class name and message are self-describing. Leaving
as-is.
##########
superset/translations/fi/LC_MESSAGES/messages.po:
##########
@@ -8152,6 +8152,9 @@ msgstr "Tietokannan asetukset päivitetty"
msgid "Database type does not support file uploads."
msgstr "Tietokantityyppi ei tue tiedostojen lataamista."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
These catalogs are extracted with empty `msgstr` by design, same as every
other locale until translators fill them in, so gettext falls back to English.
Translating it here would just get overwritten on the next extraction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
