codeant-ai-for-open-source[bot] commented on code in PR #40860:
URL: https://github.com/apache/superset/pull/40860#discussion_r3407722416
##########
superset/commands/database/exceptions.py:
##########
@@ -118,6 +118,11 @@ class DatabaseUploadFailed(CommandException):
message = _("Database upload file failed")
+class DatabaseUploadFileTooLarge(CommandException):
+ status = 413
+ message = _("Database upload file exceeds the maximum allowed size.")
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag empty gettext msgstr entries in translation catalog files;
they are intentionally left blank until translators provide localized text and
will be regenerated on extraction.
**Applied to:**
- `**/*.po`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset/translations/fi/LC_MESSAGES/messages.po:
##########
@@ -8152,6 +8152,9 @@ msgstr "Tietokannan asetukset päivitetty"
msgid "Database type does not support file uploads."
msgstr "Tietokantityyppi ei tue tiedostojen lataamista."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag empty `msgstr` entries in generated translation catalog files;
they are expected placeholders until translators fill them in and will be
overwritten on the next extraction.
**Applied to:**
- `**/*.po`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset/commands/database/exceptions.py:
##########
@@ -118,6 +118,11 @@ class DatabaseUploadFailed(CommandException):
message = _("Database upload file failed")
+class DatabaseUploadFileTooLarge(CommandException):
+ status = 413
+ message = _("Database upload file exceeds the maximum allowed size.")
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require docstrings for new exception classes in this module; keep
exception-class style consistent with the existing classes in this file.
**Applied to:**
- `superset/commands/database/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
