rusackas commented on PR #40860:
URL: https://github.com/apache/superset/pull/40860#issuecomment-4699761419
@sha174n thanks - the 100 MB-vs-`None` thing was a stale summary, you're
right. The default *is* intentional (it's the knob from #40637), so I
reconciled the PR body and added an UPDATING.md note flagging the behavior
change rather than reverting to `None`.
On the 413 schema: every FAB shared response in this file (400/401/422)
documents `{message: string}` even though `CommandException`s actually
serialize as the `errors: [...]` envelope, so the 413 was just matching the
house style. Happy to switch it to the real envelope shape, but then it'd be
the one response in the file that's accurate while the rest stay wrong... do
you think it's worth diverging here, or is that a broader cleanup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
