sha174n commented on PR #40860: URL: https://github.com/apache/superset/pull/40860#issuecomment-4699643539
Thanks, the restored non-seekable guard and the metadata 413 test look good. Two things in the latest version worth a look: 1. `UPLOAD_MAX_FILE_SIZE_BYTES` now defaults to `100 * 1024 * 1024` rather than `None`, so the limit is on by default and the feature is no longer opt-in. The summary and UPDATING.md still say it defaults to `None` (no limit). Worth either reverting to `None` or making the 100 MB default intentional and documenting the behavior change. 2. The 413 OpenAPI schema documents a top-level `message`, but `DatabaseUploadFileTooLarge` is a `CommandException`, which serializes as the standard `errors: [...]` envelope, so the documented shape should match that for generated clients. (codeant flagged this one too.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
