sadpandajoe commented on code in PR #39914: URL: https://github.com/apache/superset/pull/39914#discussion_r3507449479
########## UPDATING.md: ########## @@ -228,6 +170,8 @@ Schedule the cutover in a quiet window. Runtime reads use only the single config The migration is transactional (all-or-nothing) and idempotent — it can be safely re-run or resumed. Note that AES-GCM, unlike AES-CBC, does not support querying directly over encrypted columns; audit any code that filters on an encrypted column before switching. See the SIP at `docs/sip/authenticated-encryption-at-rest.md` for details. +- [39914](https://github.com/apache/superset/pull/39914) `ALERT_REPORT_SLACK_V2` now defaults to `True` and the legacy Slack v1 integration (`Slack` recipient type, `files.upload` API) is deprecated for removal in the next major. Slack retired `files.upload` in 2025, so v1 file-bearing sends already fail at the API level — only text-only `chat_postMessage` still works via the legacy path. Grant your Slack bot the `channels:read` scope (and `groups:read` if you use private channels) so existing `Slack` recipients can be auto-upgraded to `SlackV2` on next send. Operators who explicitly override the flag to `False` will see a one-shot `DeprecationWarning` plus a `logger.warning`; remove the override or grant the scopes to clear it. Review Comment: You're right that there was a new-vs-existing split — that's worth being precise about, so I've tightened the wording. Timeline: Slack stopped letting **new** apps register `files.upload` on **May 16, 2024**, but **existing** apps were grandfathered, so legacy integrations kept working past that date. The sunset for existing apps was originally announced for March 2025, then pushed back, and `files.upload` was finally retired for **all** apps on **November 12, 2025**. So there's no grandfathering left — every app, new or old, now gets an API error on `files.upload`, which is why Superset's v1 file-bearing sends already fail rather than "will eventually." I went a bit more specific than the "eventual retirement" framing precisely because that window has since closed. Updated the entry to call out both dates and the new-vs-existing distinction. Refs: https://docs.slack.dev/changelog/2024/05/16/apps/ (new-app cutoff) and https://docs.slack.dev/changelog/2025/03/17/files-upload-extension/ (final Nov 12 2025 retirement). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
