codeant-ai-for-open-source[bot] commented on code in PR #39914:
URL: https://github.com/apache/superset/pull/39914#discussion_r3507461727
##########
tests/unit_tests/utils/slack_test.py:
##########
@@ -287,3 +297,226 @@ def test_handle_pagination_multiple_pages(self, mocker):
{"name": "general", "id": "C12345"},
{"name": "random", "id": "C67890"},
]
+
+
+# ---------------------------------------------------------------------------
+# should_use_v2_api: drives the v1→v2 auto-upgrade decision and emits
+# DeprecationWarning + logger.warning for both no-flag and missing-scope cases.
+# ---------------------------------------------------------------------------
+
+
[email protected](autouse=True)
+def _reset_v1_warning_caches():
+ """Each test sees fresh once-per-process warning state.
+
+ The deprecation emitters are wrapped in `functools.cache` to give
+ thread-safe one-shot semantics in production. Tests need them to fire
+ again, so we clear the cache before and after each case.
+ """
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+ yield
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+
+
+class TestShouldUseV2Api:
+ def test_returns_true_when_flag_on_and_scopes_present(self, mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.return_value = {
+ "channels": [{"id": "C1", "name": "general"}]
+ }
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is True
+ assert not any(issubclass(w.category, DeprecationWarning) for w in
caught)
+ mock_client.conversations_list.assert_called_once_with(
+ limit=1,
+ exclude_archived=True,
+ types="public_channel,private_channel",
+ )
+
+ def test_returns_false_when_flag_off_and_emits_deprecation_once(self,
mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=False,
+ )
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False # second call: no new warning
+ assert should_use_v2_api() is False # third call: no new warning
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ # Exactly one DeprecationWarning across three calls.
+ assert len(deprecation_warnings) == 1
+ assert str(deprecation_warnings[0].message) ==
_SLACK_V1_DEPRECATION_MESSAGE
+ # logger.warning fires only once for the same reason.
+ assert logger_mock.warning.call_count == 1
+ assert (
+ "ALERT_REPORT_SLACK_V2 is disabled" in
logger_mock.warning.call_args.args[0]
+ )
+
+ def test_returns_false_when_scope_missing_and_emits_deprecation_once(self,
mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ # The Slack SDK exposes the error code as `response["error"]`; that is
+ # what `should_use_v2_api` branches on to decide whether the v1
+ # deprecation warning is the appropriate signal.
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message="missing_scope", response={"ok": False, "error":
"missing_scope"}
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ # DeprecationWarning emitted exactly once across multiple calls.
+ assert len(deprecation_warnings) == 1
+ assert str(deprecation_warnings[0].message) ==
_SLACK_V1_DEPRECATION_MESSAGE
+ # The user-visible scope-missing log fires every time, since operators
+ # need to see the actionable message in their report-execution logs.
+ assert logger_mock.warning.call_count == 3
+ for c in logger_mock.warning.call_args_list:
+ assert "channels:read" in c.args[0]
+ assert "groups:read" in c.args[0]
+
+ def test_scope_missing_detected_via_slack_response_data_shape(self,
mocker):
+ """The real Slack SDK sets `SlackApiError.response` to a
`SlackResponse`
+ whose payload lives in `.data` — not a plain dict. This is the
+ production-default code path, so it must be exercised directly:
+ `should_use_v2_api` reads the error code via `getattr(response,
"data")`
+ and the scope-missing branch must still fire.
+ """
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ # MockResponse mirrors SlackResponse: the error payload is on `.data`,
+ # exactly as the live SDK delivers it.
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message="missing_scope",
+ response=MockResponse({"ok": False, "error": "missing_scope"}),
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ assert len(deprecation_warnings) == 1
+ assert logger_mock.warning.call_count == 1
+ assert "channels:read" in logger_mock.warning.call_args.args[0]
+
+ @pytest.mark.parametrize(
+ "error_code",
+ ["invalid_auth", "ratelimited", "fatal_error", "account_inactive", ""],
+ )
+ def test_returns_false_without_scope_warning_on_other_slack_errors(
+ self, error_code: str, mocker
+ ):
+ """Non-scope `SlackApiError` codes must NOT be reported as a missing
+ scope — that mislabels invalid_auth, ratelimited, or server-side
+ failures as a permission problem and sends operators chasing the wrong
+ fix. The probe still falls back to v1 so the send isn't lost, but the
+ log line is generic and no DeprecationWarning fires.
+ """
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message=error_code or "unknown",
+ response={"ok": False, "error": error_code}
+ if error_code
+ else {"ok": False},
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ assert deprecation_warnings == []
+ assert logger_mock.warning.call_count == 1
+ msg = logger_mock.warning.call_args.args[0]
+ assert "probe failed" in msg
+ assert "channels:read" not in msg
+
Review Comment:
**Suggestion:** Add a type annotation for the untyped parameter and declare
the method return type explicitly. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The method annotates error_code but leaves mocker untyped and also omits a
return type. That is a real instance of the custom type-hints rule.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2ff16d7889334426837455f6deffa9e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2ff16d7889334426837455f6deffa9e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/utils/slack_test.py
**Line:** 440:475
**Comment:**
*Custom Rule: Add a type annotation for the untyped parameter and
declare the method return type explicitly.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=35cbd0829c0d27c75c6935f6c43d9419874f5d6a8bca1d7a3d47b257995ad331&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=35cbd0829c0d27c75c6935f6c43d9419874f5d6a8bca1d7a3d47b257995ad331&reaction=dislike'>👎</a>
##########
tests/unit_tests/utils/slack_test.py:
##########
@@ -287,3 +297,226 @@ def test_handle_pagination_multiple_pages(self, mocker):
{"name": "general", "id": "C12345"},
{"name": "random", "id": "C67890"},
]
+
+
+# ---------------------------------------------------------------------------
+# should_use_v2_api: drives the v1→v2 auto-upgrade decision and emits
+# DeprecationWarning + logger.warning for both no-flag and missing-scope cases.
+# ---------------------------------------------------------------------------
+
+
[email protected](autouse=True)
+def _reset_v1_warning_caches():
+ """Each test sees fresh once-per-process warning state.
+
+ The deprecation emitters are wrapped in `functools.cache` to give
+ thread-safe one-shot semantics in production. Tests need them to fire
+ again, so we clear the cache before and after each case.
+ """
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+ yield
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+
+
+class TestShouldUseV2Api:
+ def test_returns_true_when_flag_on_and_scopes_present(self, mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.return_value = {
+ "channels": [{"id": "C1", "name": "general"}]
+ }
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is True
+ assert not any(issubclass(w.category, DeprecationWarning) for w in
caught)
+ mock_client.conversations_list.assert_called_once_with(
+ limit=1,
+ exclude_archived=True,
+ types="public_channel,private_channel",
+ )
+
Review Comment:
**Suggestion:** Add missing type hints for the test method parameters and
include an explicit None return type. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This new test method omits type hints for both parameters and does not
declare a return type. That matches the custom rule violation for modified
Python code lacking annotations.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a866b97d54b44c6d9f7725191e5920a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a866b97d54b44c6d9f7725191e5920a5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/utils/slack_test.py
**Line:** 324:344
**Comment:**
*Custom Rule: Add missing type hints for the test method parameters and
include an explicit None return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=39995bd369da935fdbffa28c7c94616722784b05e9b039aaab12c202dabdecb2&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=39995bd369da935fdbffa28c7c94616722784b05e9b039aaab12c202dabdecb2&reaction=dislike'>👎</a>
##########
tests/unit_tests/utils/slack_test.py:
##########
@@ -287,3 +297,226 @@ def test_handle_pagination_multiple_pages(self, mocker):
{"name": "general", "id": "C12345"},
{"name": "random", "id": "C67890"},
]
+
+
+# ---------------------------------------------------------------------------
+# should_use_v2_api: drives the v1→v2 auto-upgrade decision and emits
+# DeprecationWarning + logger.warning for both no-flag and missing-scope cases.
+# ---------------------------------------------------------------------------
+
+
[email protected](autouse=True)
+def _reset_v1_warning_caches():
+ """Each test sees fresh once-per-process warning state.
+
+ The deprecation emitters are wrapped in `functools.cache` to give
+ thread-safe one-shot semantics in production. Tests need them to fire
+ again, so we clear the cache before and after each case.
+ """
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+ yield
+ _emit_v1_flag_off_deprecation.cache_clear()
+ _emit_v1_scope_missing_deprecation.cache_clear()
+
+
+class TestShouldUseV2Api:
+ def test_returns_true_when_flag_on_and_scopes_present(self, mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.return_value = {
+ "channels": [{"id": "C1", "name": "general"}]
+ }
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is True
+ assert not any(issubclass(w.category, DeprecationWarning) for w in
caught)
+ mock_client.conversations_list.assert_called_once_with(
+ limit=1,
+ exclude_archived=True,
+ types="public_channel,private_channel",
+ )
+
+ def test_returns_false_when_flag_off_and_emits_deprecation_once(self,
mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=False,
+ )
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False # second call: no new warning
+ assert should_use_v2_api() is False # third call: no new warning
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ # Exactly one DeprecationWarning across three calls.
+ assert len(deprecation_warnings) == 1
+ assert str(deprecation_warnings[0].message) ==
_SLACK_V1_DEPRECATION_MESSAGE
+ # logger.warning fires only once for the same reason.
+ assert logger_mock.warning.call_count == 1
+ assert (
+ "ALERT_REPORT_SLACK_V2 is disabled" in
logger_mock.warning.call_args.args[0]
+ )
+
+ def test_returns_false_when_scope_missing_and_emits_deprecation_once(self,
mocker):
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ # The Slack SDK exposes the error code as `response["error"]`; that is
+ # what `should_use_v2_api` branches on to decide whether the v1
+ # deprecation warning is the appropriate signal.
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message="missing_scope", response={"ok": False, "error":
"missing_scope"}
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ # DeprecationWarning emitted exactly once across multiple calls.
+ assert len(deprecation_warnings) == 1
+ assert str(deprecation_warnings[0].message) ==
_SLACK_V1_DEPRECATION_MESSAGE
+ # The user-visible scope-missing log fires every time, since operators
+ # need to see the actionable message in their report-execution logs.
+ assert logger_mock.warning.call_count == 3
+ for c in logger_mock.warning.call_args_list:
+ assert "channels:read" in c.args[0]
+ assert "groups:read" in c.args[0]
+
+ def test_scope_missing_detected_via_slack_response_data_shape(self,
mocker):
+ """The real Slack SDK sets `SlackApiError.response` to a
`SlackResponse`
+ whose payload lives in `.data` — not a plain dict. This is the
+ production-default code path, so it must be exercised directly:
+ `should_use_v2_api` reads the error code via `getattr(response,
"data")`
+ and the scope-missing branch must still fire.
+ """
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ # MockResponse mirrors SlackResponse: the error payload is on `.data`,
+ # exactly as the live SDK delivers it.
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message="missing_scope",
+ response=MockResponse({"ok": False, "error": "missing_scope"}),
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ assert len(deprecation_warnings) == 1
+ assert logger_mock.warning.call_count == 1
+ assert "channels:read" in logger_mock.warning.call_args.args[0]
+
+ @pytest.mark.parametrize(
+ "error_code",
+ ["invalid_auth", "ratelimited", "fatal_error", "account_inactive", ""],
+ )
+ def test_returns_false_without_scope_warning_on_other_slack_errors(
+ self, error_code: str, mocker
+ ):
+ """Non-scope `SlackApiError` codes must NOT be reported as a missing
+ scope — that mislabels invalid_auth, ratelimited, or server-side
+ failures as a permission problem and sends operators chasing the wrong
+ fix. The probe still falls back to v1 so the send isn't lost, but the
+ log line is generic and no DeprecationWarning fires.
+ """
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.side_effect = SlackApiError(
+ message=error_code or "unknown",
+ response={"ok": False, "error": error_code}
+ if error_code
+ else {"ok": False},
+ )
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ with warnings.catch_warnings(record=True) as caught:
+ warnings.simplefilter("always")
+ assert should_use_v2_api() is False
+
+ deprecation_warnings = [
+ w for w in caught if issubclass(w.category, DeprecationWarning)
+ ]
+ assert deprecation_warnings == []
+ assert logger_mock.warning.call_count == 1
+ msg = logger_mock.warning.call_args.args[0]
+ assert "probe failed" in msg
+ assert "channels:read" not in msg
+
+ @pytest.mark.parametrize(
+ "exception",
+ [
+ SlackClientNotConnectedError("transport closed"),
+ SlackRequestError("bad request args"),
+ ],
+ )
+ def test_returns_false_on_slack_sdk_client_error_from_probe(
+ self, exception: Exception, mocker
+ ):
+ """Non-`SlackApiError` SDK failures (e.g.
`SlackClientNotConnectedError`,
+ `SlackRequestError`) are not subclasses of `SlackApiError`, so before
the
+ fix they escaped the probe raw. Because `should_use_v2_api` runs
*before*
+ the mapped Slack send `try`, that aborted the whole recipient loop
instead
+ of failing a single recipient. The probe must now treat any SDK client
+ error as "v2 unavailable" and fall back to the deprecated v1 API so the
+ send still flows through the per-recipient error handling.
+ """
+ mocker.patch(
+ "superset.utils.slack.feature_flag_manager.is_feature_enabled",
+ return_value=True,
+ )
+ mock_client = mocker.Mock()
+ mock_client.conversations_list.side_effect = exception
+ mocker.patch("superset.utils.slack.get_slack_client",
return_value=mock_client)
+ logger_mock = mocker.patch("superset.utils.slack.logger")
+
+ assert should_use_v2_api() is False
+ assert logger_mock.warning.call_count == 1
+ assert "probe failed to connect" in
logger_mock.warning.call_args.args[0]
+
Review Comment:
**Suggestion:** Type-annotate the remaining untyped parameter and specify an
explicit None return type on this new test method. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The signature still leaves mocker untyped and lacks an explicit return
annotation. Since this is modified Python code, it correctly falls under the
type-hints rule.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7c0b94fdf9c64a5895e588a9e79b0efe&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7c0b94fdf9c64a5895e588a9e79b0efe&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/utils/slack_test.py
**Line:** 483:506
**Comment:**
*Custom Rule: Type-annotate the remaining untyped parameter and specify
an explicit None return type on this new test method.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=268e8c95c32b7d9136c93b08140ffcda2e12256301ce1743e57734a1b5fa74f9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=268e8c95c32b7d9136c93b08140ffcda2e12256301ce1743e57734a1b5fa74f9&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
