Pawansingh3889 commented on PR #39118: URL: https://github.com/apache/superset/pull/39118#issuecomment-4875092582
Thanks @EnxDev — all three points addressed: - Merged master and renamed the occurrence in `SliceHeaderControls.subdirectory.test.tsx` that #39925 introduced after my last rebase (c2857f7). A repo-wide grep for `supersetCanCSV` / `superset_can_csv` / `superset-can-csv` now comes back clean against the merged tree. - Title spelled out to `(#24290)` so the squash commit message inherits it properly. - Agreed on the label and the stale changes-requested review — happy for a maintainer to drop/dismiss them whenever convenient, since both refer to the behaviour change that is no longer in this PR. CI may be sitting on the workflow-approval gate again after the push — @rusackas, same favour as last time if so. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
