bito-code-review[bot] commented on code in PR #39118:
URL: https://github.com/apache/superset/pull/39118#discussion_r3523786882
##########
superset-frontend/src/dashboard/actions/hydrate.ts:
##########
@@ -353,7 +353,7 @@ export const hydrateDashboard =
'Superset',
roles,
),
- superset_can_csv: findPermission('can_csv', 'Superset', roles),
+ superset_can_download: findPermission('can_csv', 'Superset', roles),
Review Comment:
<!-- Bito Reply -->
The suggestion to update the permission check is technically correct for the
long-term goal of supporting granular export controls. However, since the
wiring for `GranularExportControls` is intentionally deferred to a follow-up
PR, you should maintain the current pure rename and address this logic update
in that subsequent PR as planned.
**superset-frontend/src/dashboard/actions/hydrate.ts**
```
- superset_can_download: findPermission('can_csv', 'Superset',
roles),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
