Pawansingh3889 commented on PR #39118: URL: https://github.com/apache/superset/pull/39118#issuecomment-4883549679
@jaymasiwal requesting a re-review when you have a moment. The concern behind your April review was the hardcoded `can_csv` check in `hydrate.ts`; that change was removed from this PR in June at @rusackas's suggestion, and the current diff is the pure rename that #24290 asked for, with no permission behaviour change. CI is green against master as of c2857f7 and a repo-wide grep for the old name comes back clean. Happy to adjust if anything else stands out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
