bito-code-review[bot] commented on code in PR #39118:
URL: https://github.com/apache/superset/pull/39118#discussion_r3523787177
##########
tests/integration_tests/security/api_tests.py:
##########
@@ -275,8 +276,9 @@ def
test_guest_validator_hook_real_world_example_positive(self):
@with_config(
{
- "GUEST_TOKEN_VALIDATOR_HOOK": lambda x: len(x["rls"]) == 1
- and "tenant_id=" in x["rls"][0]["clause"]
+ "GUEST_TOKEN_VALIDATOR_HOOK": lambda x: (
+ len(x["rls"]) == 1 and "tenant_id=" in x["rls"][0]["clause"]
+ )
Review Comment:
<!-- Bito Reply -->
The suggestion to update the `GUEST_TOKEN_VALIDATOR_HOOK` logic is
technically sound for improving robustness, but it is not applicable to this
pull request. The commit that introduced this test file and the associated
logic has been reverted to maintain this PR as a pure rename. You should ignore
this suggestion for now, as the code it refers to is no longer part of the
current diff.
##########
tests/integration_tests/security/api_tests.py:
##########
@@ -275,8 +276,9 @@ def
test_guest_validator_hook_real_world_example_positive(self):
@with_config(
{
- "GUEST_TOKEN_VALIDATOR_HOOK": lambda x: len(x["rls"]) == 1
- and "tenant_id=" in x["rls"][0]["clause"]
+ "GUEST_TOKEN_VALIDATOR_HOOK": lambda x: (
+ len(x["rls"]) == 1 and "tenant_id=" in x["rls"][0]["clause"]
+ )
Review Comment:
<!-- Bito Reply -->
The code changes in this file were part of a cherry-picked commit that has
since been reverted to keep this pull request focused on a pure rename. As a
result, this file is no longer part of the current diff, and no action is
required here for this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
