rusackas commented on code in PR #39118:
URL: https://github.com/apache/superset/pull/39118#discussion_r3523786677
##########
superset-frontend/src/dashboard/actions/hydrate.ts:
##########
@@ -353,7 +353,7 @@ export const hydrateDashboard =
'Superset',
roles,
),
- superset_can_csv: findPermission('can_csv', 'Superset', roles),
+ superset_can_download: findPermission('can_csv', 'Superset', roles),
Review Comment:
This is the `can_export_data` switch we deliberately pulled back out of this
PR... it'll land in a follow-up with a `can_csv` fallback so nobody loses the
download button silently. Keeping this one a pure rename.
##########
superset-frontend/src/dashboard/actions/hydrate.ts:
##########
@@ -353,7 +353,7 @@ export const hydrateDashboard =
'Superset',
roles,
),
- superset_can_csv: findPermission('can_csv', 'Superset', roles),
+ superset_can_download: findPermission('can_csv', 'Superset', roles),
Review Comment:
Same as the CodeAnt thread above... the `GranularExportControls` wiring is
intentionally deferred to a follow-up PR. This one stays a pure rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
