bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3557700725
##########
superset-frontend/src/explore/components/controls/SelectControl.test.tsx:
##########
@@ -414,8 +410,9 @@ describe('SelectControl', () => {
// The SelectControl should receive a sortComparator for numeric values
// This is tested by verifying the component renders without errors
+ // antd v6 places the aria-label on the Select's input element.
const selectorWrapper = screen.getByLabelText('Row Limit', {
- selector: 'div',
+ selector: 'input',
});
expect(selectorWrapper).toBeInTheDocument();
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add an assertion for sorted order is a valid
recommendation for improving test coverage. Since the current test only
verifies that the component renders without errors, adding an assertion to
check the actual sorted order of the options would confirm that the sorting
logic is functioning as expected. If you are confident that the sorting logic
is already sufficiently covered by unit tests elsewhere, you may choose to
leave the test as-is, but adding this assertion would provide additional
verification within the component's integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
