codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3562218146
##########
superset-frontend/cypress-base/cypress/e2e/explore/utils.ts:
##########
@@ -53,9 +53,7 @@ export function saveChartToDashboard(chartName: string,
dashboardName: string) {
.then($modal => {
cy.wait(500);
cy.wrap($modal)
- .find(
- '.ant-select-selection-search-input[aria-label*="Select a
dashboard"]',
- )
+ .find('.ant-select-input[aria-label*="Select a dashboard"]')
.type(dashboardName, { force: true });
Review Comment:
**Suggestion:** Migrate this updated end-to-end interaction to a Playwright
test flow instead of extending Cypress-based test logic in this file.
[custom_rule]
**Severity Level:** Major ⚠️
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a changed end-to-end test utility in a Cypress file, and the new
code continues to use Cypress APIs (`cy.wrap`, `.find`, `.type`). The rule
explicitly requires Playwright instead of Cypress for new or changed E2E test
code, so the suggestion identifies a real violation.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.github/copilot-instructions.md (line 40)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d74a1911154c4c61bf56aceed60e0dd8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d74a1911154c4c61bf56aceed60e0dd8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/explore/utils.ts
**Line:** 55:57
**Comment:**
*Custom Rule: Migrate this updated end-to-end interaction to a
Playwright test flow instead of extending Cypress-based test logic in this file.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=47e77a6e621f56b480c6f0b48bd184dffc5590b56b698cf5f4ed6541d02193a3&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=47e77a6e621f56b480c6f0b48bd184dffc5590b56b698cf5f4ed6541d02193a3&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
