rusackas commented on code in PR #42126:
URL: https://github.com/apache/superset/pull/42126#discussion_r3616392933
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/Contour.tsx:
##########
@@ -113,12 +107,6 @@ export const getLayer: GetLayerType<ContourLayer> =
function ({
},
);
- if (jsFnMutator) {
- // Applying user defined data mutator if defined
- const jsFnMutatorFunction = sandboxedEval(fd.js_data_mutator);
- data = jsFnMutatorFunction(data);
- }
-
// Create wrapper for tooltip content that adds nearby points
const tooltipContentGenerator = (o: any) => {
// Find nearby points based on hover coordinate
Review Comment:
That any usage predates this PR, we only removed the js_data_mutator
plumbing above it. Fair nit on its own, but out of scope here.
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/Contour.tsx:
##########
@@ -69,13 +68,8 @@ export const getLayer: GetLayerType<ContourLayer> = function
({
emitCrossFilters,
}) {
const fd = formData;
- const {
- aggregation = 'SUM',
- js_data_mutator: jsFnMutator,
- contours: rawContours,
- cellSize = '200',
- } = fd;
- let data = payload.data.features;
+ const { aggregation = 'SUM', contours: rawContours, cellSize = '200' } = fd;
+ const data = payload.data.features;
Review Comment:
Same story, that line predates this PR. We just dropped the mutator code
right below it, didn't touch the features access itself. Worth a guard on its
own but not something this cleanup should take on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
