rusackas commented on code in PR #42126:
URL: https://github.com/apache/superset/pull/42126#discussion_r3620140668
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Path/buildQuery.ts:
##########
@@ -32,7 +32,6 @@ export interface DeckPathFormData extends SqlaFormData {
line_type?: 'polyline' | 'json' | 'geohash';
metric?: string;
reverse_long_lat?: boolean;
- js_columns?: string[];
tooltip_contents?: unknown[];
Review Comment:
Bito's right the frontend control is gone, but `get_js_columns` and its test
stay on purpose. Old saved charts can still have `js_columns` in their
form_data, and that deprecated viz.py path needs to keep rendering them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
